docs(openapi): tighten workspace API key description field (BE-1004)#13996
Conversation
Aligns the OSS spec with the cloud-side BE-1004 contract:
- createWorkspaceApiKey request body: add maxLength: 5000 to the
description property (matches cloud's hub_profile.description
MaxLen(5000) convention; enforced cloud-side via handler check).
- WorkspaceApiKey + WorkspaceApiKeyCreated response schemas:
mark description as required (cloud's handler always populates
the field, defaulting to empty string when not supplied on create),
drop nullable: true, add maxLength: 5000 for symmetry, and clarify
the doc string ("Always present in responses; empty string when no
description was supplied on create").
Both schemas are tagged x-runtime: [cloud] at the schema level so the
tightening is correctly scoped — OSS-only implementations are not
required to honor the workspace API keys endpoints at all.
Related cloud PR: Comfy-Org/cloud#3747
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the OpenAPI specification for the workspace API key endpoint to enforce consistent validation on the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary
Aligns the OSS spec for the workspace API key endpoints with cloud's runtime contract from BE-1004.
Three small changes to
openapi.yaml:createWorkspaceApiKeyrequest body — addmaxLength: 5000to the description property (matches cloud'shub_profile.descriptionEntMaxLen(5000)convention; enforced cloud-side via handler check + Ent validator).WorkspaceApiKey+WorkspaceApiKeyCreatedresponse schemas — markdescriptionas required (cloud's handler always populates the field, defaulting to empty string when not supplied on create), dropnullable: true, addmaxLength: 5000for symmetry, and clarify the doc string ("Always present in responses; empty string when no description was supplied on create").Why
The workspace API keys schemas are tagged
x-runtime: [cloud]— they document a cloud-only endpoint surface that OSS doesn't implement. Cloud's hand-written spec (services/ingest/openapi.yamlinComfy-Org/cloud) was tightened in https://github.com/Comfy-Org/cloud/pull/3747 to reflect actual runtime behavior; this PR brings the upstream OSS contract in line so the daily vendor-sync bot can propagate the tightening back to cloud's vendor copy without drift.Scope
Spec-only. No generated code or handlers in OSS to touch — OSS has no implementation of these endpoints.
Related