Skip to content

fix: correct description of where compiled FE files live#14013

Merged
alexisrolland merged 3 commits into
masterfrom
robinjhuang-patch-1
May 24, 2026
Merged

fix: correct description of where compiled FE files live#14013
alexisrolland merged 3 commits into
masterfrom
robinjhuang-patch-1

Conversation

@robinjhuang
Copy link
Copy Markdown
Member

Clarify that build JS files are published to pypi, and don't live in the "web" directory.

Clarify that build JS files are published to pypi, and don't live in the "web" directory.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8fbfdd2-be71-4314-a4f3-ff46c4c94232

📥 Commits

Reviewing files that changed from the base of the PR and between 1a8329e and 1b7c7a1.

📒 Files selected for processing (1)
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

📝 Walkthrough

Walkthrough

This PR updates the README documentation to clarify the frontend architecture after August 15, 2024. The change corrects a statement about where compiled JavaScript files reside: they are now published to a dedicated PyPI package and installed as a ComfyUI dependency, rather than being hosted within the main repository under the web/ directory. This is a single-line documentation revision that aligns the README with the current deployment model.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: correcting the documentation to reflect where compiled frontend files are actually located.
Description check ✅ Passed The description is clearly related to the changeset, explaining that the update clarifies where built JS files are published rather than stored locally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@alexisrolland alexisrolland merged commit 32a7092 into master May 24, 2026
21 checks passed
@alexisrolland alexisrolland deleted the robinjhuang-patch-1 branch May 24, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants