Skip to content

feat(3d): reorder Preview3DAdvanced / PreviewGaussianSplat / PreviewPointCloud inputs and outputs#14308

Merged
alexisrolland merged 1 commit into
masterfrom
BE-preview-advanced-reorder-outputs
Jun 6, 2026
Merged

feat(3d): reorder Preview3DAdvanced / PreviewGaussianSplat / PreviewPointCloud inputs and outputs#14308
alexisrolland merged 1 commit into
masterfrom
BE-preview-advanced-reorder-outputs

Conversation

@jtydhr88
Copy link
Copy Markdown
Contributor

@jtydhr88 jtydhr88 commented Jun 6, 2026

Pull model_3d_info up next to model_3d in both the inputs list and the outputs list, so the two model_3d_* fields sit together at the top of each schema:

inputs: model_3d, model_3d_info, viewport_state, camera_info, width, height
outputs: model_3d, model_3d_info, camera_info, width, height

no need FE

image image

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 6, 2026

Too many files changed? Review this PR in Change Stack to see how the pieces fit before you dive in.

Review Change Stack

📝 Walkthrough

Walkthrough

This PR reorders output and input port declarations in three 3D preview nodes. The Preview3DAdvanced, PreviewGaussianSplat, and PreviewPointCloud nodes now declare and return model_3d_info before camera_info in their schemas and execution. Each node's define_schema() has been updated to place the 3D model data port before viewport/camera ports in both inputs and outputs, and each node's execute() return statement has been adjusted to match the new output order.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reordering inputs and outputs for three 3D preview nodes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the reordering of model_3d_info fields in both inputs and outputs lists for the three preview nodes, with visual examples provided.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexisrolland alexisrolland merged commit ea36cb1 into master Jun 6, 2026
16 checks passed
@jtydhr88 jtydhr88 deleted the BE-preview-advanced-reorder-outputs branch June 6, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants