Skip to content

Add some more stuff to AGENTS.md#14704

Merged
comfyanonymous merged 2 commits into
masterfrom
comfyanonymous-patch-1
Jul 1, 2026
Merged

Add some more stuff to AGENTS.md#14704
comfyanonymous merged 2 commits into
masterfrom
comfyanonymous-patch-1

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 76ce6d2f-1080-4182-8809-789ad2d29346

📥 Commits

Reviewing files that changed from the base of the PR and between 50e5270 and ad970c2.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

This pull request updates AGENTS.md documentation only, with no code changes. It adds a directive against dead branches, unreachable code, and unused functions in the Engineering Style section, substantially expands the Architecture Boundaries section with rules on separation, no internet requests, state ownership, interface contracts, and autograd/freezing restrictions, refines Python Style comment guidance to allow only concrete TODOs, and adds a Commit and Review Habits rule for concise PR descriptions.

Changes

Area Description
Engineering Style Added prohibition on dead branches, unreachable code, and unused functions
Architecture Boundaries Expanded with separation, no-internet, state ownership, interface contract, and autograd/freezing rules
Python Style Refined comment guidance to remove redundant comments while allowing concrete TODOs
Commit and Review Habits Added rule requiring concise, reviewable PR descriptions

Related issues: None specified.

Related PRs: None specified.

Suggested labels: documentation

Suggested reviewers: None specified.


A rabbit hops through docs at night,
Trimming dead branches, keeping it tight.
No stray requests to the internet's door,
State stays owned, contracts stay pure.
Short PRs now, no tale too long —
This bunny writes rules, then hops along. 🐇📄

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the change, but it is too vague to clearly describe the main update. Rename it to state the specific AGENTS.md guidance that was added or clarified.
Description check ❓ Inconclusive No pull request description was provided, so the intent is not clearly described. Add a short description summarizing the AGENTS.md guidance changes and their purpose.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@comfyanonymous comfyanonymous merged commit dd17deb into master Jul 1, 2026
16 checks passed
@comfyanonymous comfyanonymous deleted the comfyanonymous-patch-1 branch July 1, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants