Allow reroute to have in/out in different orientation#445
Conversation
|
nice one thanks |
|
@pythongosssss Double text should be fixed, cant really reproduce the undefined function |
|
@pythongosssss I was thinking it was a colab only bug but i loaded up a fresh install with the branch and it just worked, no error. |
|
I get the exact same bug as pythongosssss. It happens in both firefox and chromium for me on your exact branch and a clean browser. |
|
I've looked at the code again and i cant really tell what it is. ComfyUI is my first foray into Javascript and i really dont know what m doing wrong here. tested with edge, chrome and firefox with no error I can see the 2 errors and ill rework these part after a night sleep but its all guessing on my part after this vivaldi_ddVIOET1x1.mp4 |
|
I tested this PR and extended it a bit. I allowed setting the orientation of input/output to any direction and if there's overlap they just swap. I also made it possible to add multiple slots to the reroute node (input 1 goes to output 1, 2 to 2, etc). In on mobile now so I can't post the code, but I can get you a diff later. The multi-output support could probably be used to implement the "bus" functionality requested elsewhere too if you just add a mode that copies one input to all outputs. |
|
@Davemane42 This branch has a couple patches on top of yours: https://github.com/asagi4/ComfyUI/tree/input-orient It's probably not perfect, but I wasn't able to immediately break things. I worked around getDisplayName returning nulls by just making sure it never does... This probably changes the title display behaviour a bit, but at least it doesn't explode. |




took into consideration old workflows and convert the node after its configured.
also handle the old vertical/horizontal setting.
added reroute to the canvas right-click for easy access.