Save output node ID in file metadata#5235
Open
bezo97 wants to merge 1 commit intoComfy-Org:masterfrom
Open
Conversation
- nodes can access their unique IDs - output nodes like SaveImage, SaveAudio, Preview... etc. utilize this to serialize ID in the metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on solving a feature request that involves a small backend modification. In short, the goal is to display the dropped file in the node it was saved by.
To make this work I allow nodes to access their own unique id's and then modify
SaveImage,SaveAudioto write it in metadata.Related frontend PR: link, which depends on this PR to work.
Implementation details:
idfieldSaveImage,SaveAudio,Preview...etc. utilize this to serialize ID in the metadataFor reviewers:
execution.pyis correct as there were multiple IDs related to the node. Looks like they are all the same.