Add option to log non-error output to stdout#6243
Merged
comfyanonymous merged 2 commits intomasterfrom Dec 27, 2024
Merged
Conversation
- No change to default behaviour - Adds CLI argument: --log-stdout - With this arg present, any logging of a level below logging.ERROR will be sent to stdout instead of stderr
webfiltered
changed the title
webfiltered
requested review from
comfyanonymous,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
huchenlei
approved these changes
Dec 27, 2024
huchenlei
added
the
Good PR
robinjhuang
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to log non-error output to stdout
--log-stdoutlogging.ERRORwill be sent tostdoutinstead ofstderrMotivation
3rd party logging libraries sometimes treat error streams differently to regular streams. The logging library used by the desktop app tags error output with
[error]by default. Currently, there is no way to determine if output is an error or not, without parsing all text (which is brittle at best).This change allows the invoker to decide if ComfyUI should try to emulate normal executable output (rather than python logging default).