remove some params from load 3d node#6436
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom Jan 22, 2025
Merged
Conversation
jtydhr88
requested review from
Kosinkadink,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
huchenlei
approved these changes
Jan 12, 2025
Contributor
|
Will merge after frontend update reaches main repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I remove some params from input list and move them to threejs scene directly, this is because users are requesting new features, if we keep adding new params to input list, this list will grow up too long, which is not a good design I believe. so I start to redesign the UI,
FE change is here Comfy-Org/ComfyUI_frontend#2230
and demo is
2025-01-11.23-11-52.mp4