Skip to content

improved: better frontend package installation guide#7047

Merged
comfyanonymous merged 2 commits intoComfy-Org:masterfrom
ltdrdata:improve/better_missing_front_log
Mar 3, 2025
Merged

improved: better frontend package installation guide#7047
comfyanonymous merged 2 commits intoComfy-Org:masterfrom
ltdrdata:improve/better_missing_front_log

Conversation

@ltdrdata
Copy link
Copy Markdown
Member

@ltdrdata ltdrdata commented Mar 3, 2025

improved: better installation guide

  • change pip to {sys.executable} -m pip

modified: To prevent the guide message from being obscured by a complex error message, apply exit instead of raise.

- change `pip` to `{sys.executable} -m pip`
modified: To prevent the guide message from being obscured by a complex error message, apply `exit` instead of `raise`.
@comfyanonymous comfyanonymous merged commit d6e5d48 into Comfy-Org:master Mar 3, 2025
5 checks passed
@ltdrdata ltdrdata deleted the improve/better_missing_front_log branch March 3, 2025 09:49
@mcmonkey4eva
Copy link
Copy Markdown
Contributor

This is wrong: it should be -s -m pip

The -s is critical, otherwise a venv will potentially pollute links to global python

ltdrdata added a commit to ltdrdata/ComfyUI that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip`
-> `{sys.executable} -s -m pip`

Comfy-Org#7047 (comment)
ltdrdata added a commit to ltdrdata/ComfyUI that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip` -> `{sys.executable} -s -m pip`

Comfy-Org#7047 (comment)
comfyanonymous pushed a commit that referenced this pull request Mar 6, 2025
`{sys.executable} -m pip` -> `{sys.executable} -s -m pip`

#7047 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants