Fix memory leak in preview code #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both TaskItem and the in node preview create object URL to display previews, but failed to ever revoke. This caused a memory leak. This is resolved by adding a revoke calls whenever these previews are discarded.
webfiltered
requested changes
Dec 22, 2024
webfiltered
reviewed
Dec 22, 2024
webfiltered
approved these changes
Dec 22, 2024
huchenlei
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both TaskItem and the in node preview create object URL to display previews, but fail to ever revoke. This causes a memory leak.
This is resolved by adding a revoke calls whenever these previews are discarded.
┆Issue is synchronized with this Notion page by Unito