Skip to content

fix: dynamically resolve standalone Python patch version#369

Merged
bigcat88 merged 2 commits intomainfrom
fix-dynamic-standalone-python-version
Mar 12, 2026
Merged

fix: dynamically resolve standalone Python patch version#369
bigcat88 merged 2 commits intomainfrom
fix-dynamic-standalone-python-version

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

The python-build-standalone project releases every 1-2 weeks, and each release only ships one patch version per minor series (e.g. 3.12.13 replaces 3.12.12). Since we had the full patch version hardcoded in constants.py, every new release broke standalone downloads with 404 errors until someone bumped the constant and cut a new comfy-cli release. This already happened three times (3.12.8 -> 3.12.12 -> 3.12.13).

This change pins only the minor version ("3.12") in the constant and resolves the exact patch version at download time by fetching the release's SHA256SUMS file (~45 KB) and parsing it. Full X.Y.Z versions still work if passed explicitly.

Also updates the GitHub URLs from indygreg/python-build-standalone to astral-sh/python-build-standalone (the project moved).

Follows up on #366.

… metadata

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Mar 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   52.52%   53.14%   +0.62%     
==========================================
  Files          32       32              
  Lines        3568     3588      +20     
==========================================
+ Hits         1874     1907      +33     
+ Misses       1694     1681      -13     
Files with missing lines Coverage Δ
comfy_cli/constants.py 100.00% <100.00%> (ø)
comfy_cli/standalone.py 59.61% <100.00%> (+25.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 merged commit e159777 into main Mar 12, 2026
14 checks passed
@bigcat88 bigcat88 deleted the fix-dynamic-standalone-python-version branch March 12, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant