fix: dynamically resolve standalone Python patch version#369
Merged
Conversation
… metadata Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 52.52% 53.14% +0.62%
==========================================
Files 32 32
Lines 3568 3588 +20
==========================================
+ Hits 1874 1907 +33
+ Misses 1694 1681 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python-build-standalone project releases every 1-2 weeks, and each release only ships one patch version per minor series (e.g. 3.12.13 replaces 3.12.12). Since we had the full patch version hardcoded in constants.py, every new release broke standalone downloads with 404 errors until someone bumped the constant and cut a new comfy-cli release. This already happened three times (3.12.8 -> 3.12.12 -> 3.12.13).
This change pins only the minor version ("3.12") in the constant and resolves the exact patch version at download time by fetching the release's SHA256SUMS file (~45 KB) and parsing it. Full X.Y.Z versions still work if passed explicitly.
Also updates the GitHub URLs from indygreg/python-build-standalone to astral-sh/python-build-standalone (the project moved).
Follows up on #366.