fix: apply --pr validation and passthrough for --cpu install path#370
Merged
fix: apply --pr validation and passthrough for --cpu install path#370
Conversation
dosubot
bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 53.14% 53.31% +0.16%
==========================================
Files 32 32
Lines 3588 3588
==========================================
+ Hits 1907 1913 +6
+ Misses 1681 1675 -6
🚀 New features to boost your workflow:
|
The --pr/--version/--commit conflict check was placed after the `if cpu:` early return, so --cpu --pr silently ignored the PR. Also the CPU path never passed pr= to install_inner.execute. Move validation above the early return and pass pr=pr in the CPU path.
bigcat88
force-pushed
the
fix-cpu-pr-validation
branch
from
b94f0ae to
7e6bf6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --pr/--version/--commit conflict check was placed after the
if cpu:early return, socomfy install --cpu --pr 123silently ignored the PR reference. The CPU path also never passed pr= to install_inner.execute.Moved the validation before the early return and added pr=pr to the CPU install path.
Spotted in #365 (comment)