fix: use --index-url for AMD ROCm torch install, add --rocm-version flag#379
Merged
fix: use --index-url for AMD ROCm torch install, add --rocm-version flag#379
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 62.99% 63.10% +0.11%
==========================================
Files 33 33
Lines 3691 3697 +6
==========================================
+ Hits 2325 2333 +8
+ Misses 1366 1364 -2
🚀 New features to boost your workflow:
|
65148e4 to
04dcf8e
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comfy install --amd installs CUDA torch instead of ROCm torch. The root cause is that --extra-index-url lets pip see both PyPI and the ROCm index simultaneously, and pip picks the higher-versioned CUDA torch from PyPI over the ROCm build.
This switches to --index-url (which replaces PyPI entirely) following PyTorch's official recommendation. Also adds a --rocm-version flag mirroring the existing --cuda-version, so users with older ROCm drivers can select their version. Default is rocm6.3.
The uv fast-deps path is also bumped from rocm6.1 to rocm6.3 for consistency.
Fixes #289