Skip to content

fix: use --index-url for AMD ROCm torch install, add --rocm-version flag#379

Merged
bigcat88 merged 2 commits intomainfrom
fix-amd-rocm-torch-install
Mar 14, 2026
Merged

fix: use --index-url for AMD ROCm torch install, add --rocm-version flag#379
bigcat88 merged 2 commits intomainfrom
fix-amd-rocm-torch-install

Conversation

@bigcat88
Copy link
Contributor

comfy install --amd installs CUDA torch instead of ROCm torch. The root cause is that --extra-index-url lets pip see both PyPI and the ROCm index simultaneously, and pip picks the higher-versioned CUDA torch from PyPI over the ROCm build.

This switches to --index-url (which replaces PyPI entirely) following PyTorch's official recommendation. Also adds a --rocm-version flag mirroring the existing --cuda-version, so users with older ROCm drivers can select their version. Default is rocm6.3.

The uv fast-deps path is also bumped from rocm6.1 to rocm6.3 for consistency.

Fixes #289

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   62.99%   63.10%   +0.11%     
==========================================
  Files          33       33              
  Lines        3691     3697       +6     
==========================================
+ Hits         2325     2333       +8     
+ Misses       1366     1364       -2     
Files with missing lines Coverage Δ
comfy_cli/cmdline.py 58.00% <100.00%> (ø)
comfy_cli/command/install.py 70.86% <100.00%> (+0.39%) ⬆️
comfy_cli/constants.py 100.00% <100.00%> (ø)
comfy_cli/uv.py 55.89% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 force-pushed the fix-amd-rocm-torch-install branch from 65148e4 to 04dcf8e Compare March 14, 2026 11:25
@bigcat88 bigcat88 marked this pull request as ready for review March 14, 2026 12:48
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 14, 2026
@bigcat88 bigcat88 merged commit 88a2021 into main Mar 14, 2026
16 of 17 checks passed
@bigcat88 bigcat88 deleted the fix-amd-rocm-torch-install branch March 14, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Found no NVIDIA driver

1 participant