fix: make e2e test_node resilient to transient git clone failures#381
Merged
fix: make e2e test_node resilient to transient git clone failures#381
Conversation
2599a63 to
e337ea6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 63.44% 63.44%
=======================================
Files 33 33
Lines 3699 3699
=======================================
Hits 2347 2347
Misses 1352 1352 🚀 New features to boost your workflow:
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_node e2etest flakes intermittently on all platforms (Ubuntu, macOS, Windows) becausegit cloneofcomfyui-animatediff-evolvedfails with exit code 128 due to GitHub rate-limiting on Actions runners.Two problems made this worse than it needed to be.
First,
comfy node installreturns exit code 0 even when git clone fails internally (ComfyUI-Manager's cm-cli.py swallows the exception). The test passed the returncode check and then failed with a confusing "node not in list" assertion.Second, a single transient network error caused the whole test to fail with no retry.
This adds
--exit-on-failto the install command so the CLI properly reports failure, and wraps the install in a retry loop (3 attempts) to handle transient network errors.