Skip to content

fix: make e2e test_node resilient to transient git clone failures#381

Merged
bigcat88 merged 1 commit intomainfrom
fix-flaky-test-node-e2e
Mar 14, 2026
Merged

fix: make e2e test_node resilient to transient git clone failures#381
bigcat88 merged 1 commit intomainfrom
fix-flaky-test-node-e2e

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Mar 14, 2026

The test_node e2e test flakes intermittently on all platforms (Ubuntu, macOS, Windows) because git clone of comfyui-animatediff-evolved fails with exit code 128 due to GitHub rate-limiting on Actions runners.

Two problems made this worse than it needed to be.
First, comfy node install returns exit code 0 even when git clone fails internally (ComfyUI-Manager's cm-cli.py swallows the exception). The test passed the returncode check and then failed with a confusing "node not in list" assertion.
Second, a single transient network error caused the whole test to fail with no retry.

This adds --exit-on-fail to the install command so the CLI properly reports failure, and wraps the install in a retry loop (3 attempts) to handle transient network errors.

@bigcat88 bigcat88 force-pushed the fix-flaky-test-node-e2e branch from 2599a63 to e337ea6 Compare March 14, 2026 15:27
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files          33       33           
  Lines        3699     3699           
=======================================
  Hits         2347     2347           
  Misses       1352     1352           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 marked this pull request as ready for review March 14, 2026 15:49
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Mar 14, 2026
@bigcat88 bigcat88 merged commit c106693 into main Mar 14, 2026
23 checks passed
@bigcat88 bigcat88 deleted the fix-flaky-test-node-e2e branch March 14, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant