fix: --fast-deps now respects --skip-torch-or-directml#382
Merged
Conversation
7c87c89 to
776ce3a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 63.44% 63.92% +0.47%
==========================================
Files 33 33
Lines 3699 3703 +4
==========================================
+ Hits 2347 2367 +20
+ Misses 1352 1336 -16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
comfy install --fast-deps --skip-torch-or-directml, the--skip-torch-or-directmlflag was silently ignored. TheDependencyCompilerhad no awareness of this flag and always configured PyTorch index URLs and wrote torch packages into the override file.Added a
skip_torchparameter toDependencyCompiler. When set, it prevents torch/torchvision/torchaudio from being included in the override file and skips adding PyTorch index URLs during installation. The install command now passesskip_torch_or_directmlthrough toDependencyCompiler.Added tests covering all three aspects: GPU URL/backend nullification across NVIDIA/AMD/CPU, override file content, and install command arguments.
Fixes #246