Skip to content

fix: --fast-deps now respects --skip-torch-or-directml#382

Merged
bigcat88 merged 3 commits intomainfrom
fix/fast-deps-skip-torch
Mar 15, 2026
Merged

fix: --fast-deps now respects --skip-torch-or-directml#382
bigcat88 merged 3 commits intomainfrom
fix/fast-deps-skip-torch

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented Mar 15, 2026

When using comfy install --fast-deps --skip-torch-or-directml, the --skip-torch-or-directml flag was silently ignored. The DependencyCompiler had no awareness of this flag and always configured PyTorch index URLs and wrote torch packages into the override file.

Added a skip_torch parameter to DependencyCompiler. When set, it prevents torch/torchvision/torchaudio from being included in the override file and skips adding PyTorch index URLs during installation. The install command now passes skip_torch_or_directml through to DependencyCompiler.

Added tests covering all three aspects: GPU URL/backend nullification across NVIDIA/AMD/CPU, override file content, and install command arguments.

Fixes #246

@bigcat88 bigcat88 force-pushed the fix/fast-deps-skip-torch branch from 7c87c89 to 776ce3a Compare March 15, 2026 07:27
@bigcat88 bigcat88 marked this pull request as ready for review March 15, 2026 07:57
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   63.44%   63.92%   +0.47%     
==========================================
  Files          33       33              
  Lines        3699     3703       +4     
==========================================
+ Hits         2347     2367      +20     
+ Misses       1352     1336      -16     
Files with missing lines Coverage Δ
comfy_cli/command/install.py 72.74% <ø> (ø)
comfy_cli/uv.py 64.02% <100.00%> (+6.36%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 merged commit 291b264 into main Mar 15, 2026
14 checks passed
@bigcat88 bigcat88 deleted the fix/fast-deps-skip-torch branch March 15, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using --fast-deps ignores --skip-torch-or-directml

1 participant