fix: handle unknown node IDs in comfy run without crashing#385
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 66.59% 67.04% +0.44%
==========================================
Files 33 33
Lines 3706 3711 +5
==========================================
+ Hits 2468 2488 +20
+ Misses 1238 1223 -15
🚀 New features to boost your workflow:
|
bigcat88
added a commit
that referenced
this pull request
Apr 2, 2026
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When workflows use loop/iteration nodes (like ComfyUI-Loop-image or Easy-Use), the ComfyUI server sends websocket messages with composite node IDs like
406.0.0.428that don't exist in the original workflow dict. This causedcomfy runto crash with aKeyErroreven though the workflow executed successfully and all outputs were saved.Changed
get_node_title()andlog_node()to usedict.get()instead ofdict[]for workflow lookups. Unknown node IDs now fall back to displaying the raw ID string instead of crashing. The workflow execution itself is unaffected sinceremaining_nodes.discard()was already safe for unknown keys.Added tests covering unknown node IDs through all message types (executing, progress, executed, execution_cached) in both normal and
--verbosemodes.Fixes #278