test: add integration test for comfy node pack#392
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 74.22% 74.66% +0.43%
==========================================
Files 33 33
Lines 3915 3915
==========================================
+ Hits 2906 2923 +17
+ Misses 1009 992 -17 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end integration test for
comfy node pack. Creates a real git repo with a pyproject.toml, tracked files, a.comfyignore, and anincludesdirectory, then invokes the CLI and inspects the resulting zip.Verifies five behaviors in one test: git-tracked files are included,
.comfyignorepatterns exclude files even when git-tracked, untracked files are excluded,[tool.comfy] includesdirectories are force-included even when not git-tracked, and the zip file itself is not recursively included.The only thing mocked is the tracking consent prompt. Everything else runs through the real pipeline: CLI entry point, pyproject.toml parsing via
extract_node_configuration,git ls-files,.comfyignorevia pathspec, andzip_files.