Conversation
📝 WalkthroughWalkthroughThe GitHub Actions workflow configuration was streamlined by removing the entire Homebrew tap publishing pipeline while retaining PyPI publication functionality. The workflow name reflects this narrowed scope, transitioning from multi-channel distribution to a single PyPI-focused approach. Changes
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 74.71% 74.71%
=======================================
Files 33 33
Lines 3924 3924
=======================================
Hits 2932 2932
Misses 992 992 🚀 New features to boost your workflow:
|
dosubot
bot
added
the
size:M
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/publish_package.yml (1)
77-78:⚠️ Potential issue | 🟡 MinorConsider adding retry logic for PyPI eventual consistency.
PyPI has eventual consistency, and the package may not be immediately available after publishing. The commented-out TestPyPI code (lines 55-57) includes a retry loop with sleep for this exact reason, but the production pip install here has no such safeguard. This could lead to intermittent failures—a pip that slips makes the workflow trip!
🛡️ Proposed fix to add retry logic
- name: Install Comfy CLI via pip and Test - run: pip install comfy-cli==${{env.VERSION}} + run: | + for i in {1..5}; do + pip install comfy-cli==${{env.VERSION}} && break || sleep 10 + done🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/publish_package.yml around lines 77 - 78, The pip install step titled "Install Comfy CLI via pip and Test" currently runs a single pip install command (pip install comfy-cli==${{env.VERSION}}) and can fail due to PyPI eventual consistency; change this step to retry the pip install command a few times with short sleeps between attempts (e.g., loop 3–5 tries, run pip install comfy-cli==${{env.VERSION}} and if it succeeds break, otherwise sleep 10–30s and retry), and exit non-zero only after all attempts fail so intermittent publish propagation doesn't break the workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/publish_package.yml:
- Around line 77-78: The pip install step titled "Install Comfy CLI via pip and
Test" currently runs a single pip install command (pip install
comfy-cli==${{env.VERSION}}) and can fail due to PyPI eventual consistency;
change this step to retry the pip install command a few times with short sleeps
between attempts (e.g., loop 3–5 tries, run pip install
comfy-cli==${{env.VERSION}} and if it succeeds break, otherwise sleep 10–30s and
retry), and exit non-zero only after all attempts fail so intermittent publish
propagation doesn't break the workflow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 728b0dfc-47fb-4269-9aad-8bd35dc73e6e
📒 Files selected for processing (1)
.github/workflows/publish_package.yml
1 participant
Summary
Removes the
publish-homebrew-tapandtest-homebrew-installationjobs from the release workflow.The homebrew tap (Comfy-Org/homebrew-comfy-cli) has been stuck at v0.0.29 since May 2024 — the
COMMITTER_TOKENsecret expired and both jobs have failed on every release since at least v1.5.3. Zero issues have been filed about it.The recommended install paths are
pipx install comfy-cli/uv tool install comfy-clifor CLI users and the Desktop app for GUI users. The homebrew tap repo can be archived separately.Also renames the workflow from "Publish and Update Formula" to "Publish to PyPI" to reflect what it actually does now.