Skip to content

feat: add CUDA 13.0 support#398

Merged
bigcat88 merged 1 commit intomainfrom
add-cuda-13.0
Mar 30, 2026
Merged

feat: add CUDA 13.0 support#398
bigcat88 merged 1 commit intomainfrom
add-cuda-13.0

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

Adds v13_0 = "13.0" to the CUDAVersion enum so users can pass --cuda-version 13.0 when installing with --nvidia. This is needed for newer GPUs (e.g. RTX 5060 Ti) that ship with CUDA 13.0 drivers.

Without this, users with CUDA 13.0 have to manually uninstall torch and reinstall with the correct wheel outside of comfy-cli.

Related: #397

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 20c49081-8149-4cc0-94c8-22cff4135bbd

📥 Commits

Reviewing files that changed from the base of the PR and between 5dbb999 and de92665.

📒 Files selected for processing (2)
  • comfy_cli/constants.py
  • tests/uv/test_uv.py

📝 Walkthrough

Walkthrough

CUDA 13.0 support has been added to the project by introducing a new enum member to the CUDAVersion constants and verifying its integration with a unit test that validates correct torch backend and GPU URL mapping.

Changes

Cohort / File(s) Summary
CUDA Version Support
comfy_cli/constants.py
Added CUDAVersion.v13_0 enum member mapped to "13.0" to expand supported CUDA versions.
CUDA 13 Test Coverage
tests/uv/test_uv.py
Added test_nvidia_cuda_13 unit test verifying DependencyCompiler correctly maps CUDA 13.0 to "cu130" torch backend and appropriate PyTorch wheel URL—you could say this test is cuda-lly important to get right! 🔧
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-cuda-13.0
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch add-cuda-13.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   74.71%   74.72%           
=======================================
  Files          33       33           
  Lines        3924     3925    +1     
=======================================
+ Hits         2932     2933    +1     
  Misses        992      992           
Files with missing lines Coverage Δ
comfy_cli/constants.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 merged commit eb5f6e6 into main Mar 30, 2026
15 checks passed
@bigcat88 bigcat88 deleted the add-cuda-13.0 branch March 30, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant