Skip to content

feat: improve "--fast-deps" and "--uv-compile" documentation#405

Merged
bigcat88 merged 2 commits intomainfrom
improve-fast-deps-uv-compile-docs
Apr 3, 2026
Merged

feat: improve "--fast-deps" and "--uv-compile" documentation#405
bigcat88 merged 2 commits intomainfrom
improve-fast-deps-uv-compile-docs

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented Apr 2, 2026

Reference issue: #404

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ad826f45-39a4-47fd-883d-821e58334e3d

📥 Commits

Reviewing files that changed from the base of the PR and between 0e9b5df and 85c5cb3.

📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

Documents a new comfy install --fast-deps option that uses uv for dependency compilation and automatic GPU-specific PyTorch wheel selection; clarifies --uv-compile as using ComfyUI-Manager’s unified resolver with cross-node conflict detection and node attribution. Fast deps, no frets—install in sets.

Changes

Cohort / File(s) Summary
Documentation Updates
README.md
Added --fast-deps docs describing uv-based compilation of core + custom-node requirements into a single lockfile, automatic GPU wheel selection, and a comparison table plus guidance distinguishing --fast-deps vs --uv-compile (unified resolver, cross-node conflict detection, node attribution).
Help Text
comfy_cli/cmdline.py
Updated comfy install --fast-deps help text to state it uses uv (Comfy CLI’s built-in resolver) rather than pip; no control-flow or public API changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-fast-deps-uv-compile-docs
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch improve-fast-deps-uv-compile-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files          35       35           
  Lines        4143     4143           
=======================================
  Hits         3135     3135           
  Misses       1008     1008           
Files with missing lines Coverage Δ
comfy_cli/cmdline.py 57.56% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 218-220: Two lines in the README containing the sentence starting
with "`pip install`, `--uv-compile` delegates to ComfyUI-Manager's unified
resolver..." have trailing spaces at their ends; remove the trailing whitespace
from those lines (the line with "all custom node dependencies via `uv pip
compile` with **cross-node conflict detection** —" and the following line "it
can identify which node packs have incompatible dependencies and why.") so the
markdown has no trailing spaces, then re-save the file and optionally run a
markdown/whitespace linter to confirm no trailing spaces remain.
- Around line 69-71: Trailing spaces exist in the README paragraph describing
`comfy install --fast-deps`; open the README, locate the paragraph containing
the text "comfy install --fast-deps" and remove the trailing whitespace at the
ends of the affected lines so they are trimmed (ensure no extra spaces remain
after "resolution" and "installation."), then save the file to eliminate the
markdownlint warning.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f6e193bd-a6e2-4911-ac4d-86c7aea937b8

📥 Commits

Reviewing files that changed from the base of the PR and between 19f555b and 0e9b5df.

📒 Files selected for processing (2)
  • README.md
  • comfy_cli/cmdline.py

@bigcat88 bigcat88 merged commit 9dfbb45 into main Apr 3, 2026
15 checks passed
@bigcat88 bigcat88 deleted the improve-fast-deps-uv-compile-docs branch April 3, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant