Contextmenu migration #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Complete migration guide from deprecated monkey-patching to new API - Side-by-side comparisons of old vs new approaches - Canvas menu and node menu migration examples - Troubleshooting section with deprecation warnings - Recommends declarative submenu pattern
- Replace deprecated prototype monkey-patching with getCanvasMenuItems/getNodeMenuItems hooks - Update background menu examples to use modern extension API - Update node menu examples with proper type filtering - Switch to declarative submenu pattern using submenu.options - Keep original example simplicity and patterns
…-pr-508-46000' into contextmenu-migration
comfyui-wiki
added a commit
that referenced
this pull request
Oct 28, 2025
This PR synchronizes the Chinese documentation with the changes made in PR #508 (Contextmenu migration). The updates replace deprecated monkey-patching patterns with the new recommended extension hooks for context menus. Changes: - Updated background menu section to use `getCanvasMenuItems` method instead of monkey-patching `LGraphCanvas.prototype.getCanvasMenuOptions` - Updated node menu section to use `getNodeMenuItems` method instead of monkey-patching in `beforeRegisterNodeDef()` - Updated submenu section to use declarative `submenu` property with `options` array instead of `LiteGraph.ContextMenu` These changes align with the best practices introduced in the context menu migration guide and ensure Chinese documentation stays in sync with English documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
comfyui-wiki
added a commit
that referenced
this pull request
Oct 29, 2025
* Update tutorials/api-nodes/pricing.mdx * Update zh-CN/tutorials/api-nodes/pricing.mdx * Update pricing * Update pricing * Update Chinese version of javascript_examples.mdx to match PR #508 This PR synchronizes the Chinese documentation with the changes made in PR #508 (Contextmenu migration). The updates replace deprecated monkey-patching patterns with the new recommended extension hooks for context menus. Changes: - Updated background menu section to use `getCanvasMenuItems` method instead of monkey-patching `LGraphCanvas.prototype.getCanvasMenuOptions` - Updated node menu section to use `getNodeMenuItems` method instead of monkey-patching in `beforeRegisterNodeDef()` - Updated submenu section to use declarative `submenu` property with `options` array instead of `LiteGraph.ContextMenu` These changes align with the best practices introduced in the context menu migration guide and ensure Chinese documentation stays in sync with English documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix typos --------- Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive migration guide for context menu extensions in ComfyUI and updates related documentation and examples to reflect the new recommended APIs. The most important changes are the addition of a step-by-step migration guide, updates to example code to use the new extension hooks, and improvements to documentation clarity and maintainability.
Documentation: Context Menu Migration
custom-nodes/js/context-menu-migration.mdx, a detailed migration guide explaining how to move from deprecated monkey-patching of context menus to the new extension hooks (getCanvasMenuItemsandgetNodeMenuItems). The guide includes before/after code samples, troubleshooting tips, and best practices for submenus and state access.docs.json.Example Code Updates
custom-nodes/js/javascript_examples.mdxto replace deprecated monkey-patching patterns with the new extension hooks for both canvas and node menus. Examples now usegetCanvasMenuItemsandgetNodeMenuItemsmethods, demonstrating cleaner and more maintainable code.submenuproperty with anoptionsarray, aligning with the recommended API for better maintainability.Clarity and Best Practices