Sync Chinese version of javascript_examples.mdx with PR #508 #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR synchronizes the Chinese documentation with the changes made in PR #508 (Contextmenu migration). The updates replace deprecated monkey-patching patterns with the new recommended extension hooks for context menus. Changes: - Updated background menu section to use `getCanvasMenuItems` method instead of monkey-patching `LGraphCanvas.prototype.getCanvasMenuOptions` - Updated node menu section to use `getNodeMenuItems` method instead of monkey-patching in `beforeRegisterNodeDef()` - Updated submenu section to use declarative `submenu` property with `options` array instead of `LiteGraph.ContextMenu` These changes align with the best practices introduced in the context menu migration guide and ensure Chinese documentation stays in sync with English documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR synchronizes the Chinese documentation (
zh-CN/custom-nodes/js/javascript_examples.mdx) with the changes made in PR #508 (Contextmenu migration).The Chinese version was still using deprecated monkey-patching patterns while the English version has been updated to use the new recommended extension hooks.
Changes
getCanvasMenuItemsmethod instead of monkey-patchingLGraphCanvas.prototype.getCanvasMenuOptionsgetNodeMenuItemsmethod instead of monkey-patching inbeforeRegisterNodeDef()submenuproperty withoptionsarray instead ofLiteGraph.ContextMenuContext
These changes align with the best practices introduced in the context menu migration guide (PR #508) and ensure the Chinese documentation stays in sync with the English documentation.
Related
🤖 Generated with Claude Code