📦 NEW: The wp_localize_script functionality#206
Merged
Merged
Conversation
Member
|
Thanks for the PR. @ahmadbilaldev learn Emoji log better. Using both |
ahmadawais
changed the title
ahmadawais
requested changes
Aug 18, 2019
Member
ahmadawais
left a comment
ahmadawais
left a comment
There was a problem hiding this comment.
Read the comments and address the changes.
ahmadawais
reviewed
Aug 18, 2019
Co-Authored-By: Ahmad Awais ⚡️ <me@AhmadAwais.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
wp_localize_scriptin the CGB template.Problem
You can not determine the path or URL of the plugin programatically inside the blocks. This is usually done by PHP functions plugin_dir_path() and plugin_dir_url(). However, they are not accessible inside the blocks (say if one wants to include an image locally and link to it in the src tag).
Solution
In this PR, I have added an array
CGB_GLOBALcontaining dynamic data for a JS Global. The globals can now be imported inside the block JS file. More useful globals can be added in the future.