Skip to content

👌 IMPROVE: Remove unnecessary script dependencies. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyBJacobs wants to merge 1 commit into from
Closed

👌 IMPROVE: Remove unnecessary script dependencies. #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cgb-scripts/template/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function <% blockNamePHPLower %>_cgb_block_assets() {
wp_enqueue_style(
'<% blockNamePHPLower %>-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array() // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function <% blockNamePHPLower %>_cgb_block_assets().
Expand All @@ -47,7 +47,7 @@ function <% blockNamePHPLower %>_cgb_editor_assets() {
wp_enqueue_script(
'<% blockNamePHPLower %>-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ), // Dependencies, defined above.
Copy link
Copy Markdown

@ajitbohra ajitbohra May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies are required:

  1. wp-blocks handles block registration & various other block API's
  2. wp-i18n handles translations
  3. wp-element react createElement abstraction

Copy link
Copy Markdown
Member

@ahmadawais ahmadawais May 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajitbohra Can you fix this PR?

Copy link
Copy Markdown

@ajitbohra ajitbohra Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadawais sure

Copy link
Copy Markdown
Member

@ahmadawais ahmadawais Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates?! 🤔

array(), // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ), // Version: filemtime — Gets file modification time.
true // Enqueue the script in the footer.
);
Expand All @@ -56,7 +56,7 @@ function <% blockNamePHPLower %>_cgb_editor_assets() {
wp_enqueue_style(
'<% blockNamePHPLower %>-cgb-block-editor-css', // Handle.
plugins_url( 'dist/blocks.editor.build.css', dirname( __FILE__ ) ), // Block editor CSS.
array( 'wp-edit-blocks' ) // Dependency to include the CSS after it.
array() // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.editor.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function <% blockNamePHPLower %>_cgb_editor_assets().
Expand Down