Skip to content

fix pagination assert #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ltitanb merged 2 commits into from
Apr 22, 2026
+8 −6
Merged

fix pagination assert #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a371ce8
fix
ninaiiad Apr 22, 2026
19894f6
check expected number of keys
ninaiiad Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/common/src/config/mux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ async fn fetch_ssv_pubkeys_from_public_api(

let mut pubkeys: Vec<BlsPublicKey> = vec![];
let mut page = 1;
let mut expected_total: Option<usize> = None;

loop {
let route = format!(
Expand All @@ -470,21 +471,22 @@ async fn fetch_ssv_pubkeys_from_public_api(

let response = request_ssv_pubkeys_from_public_api(url, http_timeout).await?;
let fetched = response.validators.len();
if expected_total.is_none() && fetched > 0 {
expected_total = Some(response.pagination.total);
}
pubkeys.extend(
response.validators.into_iter().map(|v| v.pubkey).collect::<Vec<BlsPublicKey>>(),
);
page += 1;

if fetched < MAX_PER_PAGE {
ensure!(
pubkeys.len() == response.pagination.total,
"expected {} keys, got {}",
response.pagination.total,
pubkeys.len()
);
break;
}
}

if let Some(expected) = expected_total {
ensure!(pubkeys.len() == expected, "expected {expected} keys, got {}", pubkeys.len());
}

Ok(pubkeys)
}
Loading