Merged
Conversation
Member
|
Hey there, thanks for the PR. Do you have an example of when/where this was causing issues? |
Contributor
Author
|
Sure - if you create an adapter with 10 items, then replace it with 5 items and call notifyDataSetChanged() the resulting view would have 7 items. This is happening because the code tries to remove the child views by position 5,6,7,8,9 in that order - but once we remove child 5 the positions all shift back by one so we actually need to remove the child at position 5 each time instead (or remove it as a range like in my PR). |
Member
|
Awesome, thanks for catching this issue! |
Member
|
Released as 1.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
you can't remove views in the same loop since the positions change