Skip to content

Fix console log #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spengrah merged 2 commits into from
Oct 6, 2020
Merged

Fix console log #10

spengrah merged 2 commits into from
Oct 6, 2020

Conversation

@bitbeckers
Copy link
Member

@bitbeckers bitbeckers commented Oct 5, 2020

#3 #4

PR,

  • Configured most test set-up via waffle, removering direct use of other frameworks
  • Improved error handling in contract (reverting on out of range calls)
  • Console.log in contract now logging to terminal

Open issue:

  • Remove calledOnContract calls and find alternative for checking on contract method calls

@spengrah spengrah merged commit 25a237a into develop Oct 6, 2020
@bitbeckers bitbeckers mentioned this pull request Oct 6, 2020
Closed
@bitbeckers bitbeckers linked an issue Oct 6, 2020 that may be closed by this pull request
Invalid calls reverted with invalid opcode instead of declared message #4
Closed
@bitbeckers bitbeckers mentioned this pull request Oct 6, 2020
Closed
@bitbeckers bitbeckers deleted the fix_console_log branch December 14, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spengrah spengrah spengrah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid calls reverted with invalid opcode instead of declared message

3 participants

@bitbeckers @spengrah