Conversation
Gunoshozo
force-pushed
the
group-input-refactor
branch
from
66759a7 to
5a21bcf
Compare
Gunoshozo
force-pushed
the
group-input-refactor
branch
from
5a21bcf to
a3d9002
Compare
PringlesGang
requested changes
Feb 15, 2026
Member
There was a problem hiding this comment.
Groups that still need to get an UpdateInput call:
- src/games/darling/sysmesbox.cpp
ChoiceItems - src/games/mo6tw/sysmesbox.cpp
ChoiceItems - src/games/mo6tw/titlemenu.cpp
ContinueItems - src/games/mo6tw/titlemenu.cpp
SystemItems - src/games/mo6tw/titlemenu.cpp
ExtraStoryItems - src/games/mo6tw/titlemenu.cpp
MemoriesItems
Gunoshozo
force-pushed
the
group-input-refactor
branch
from
08390d9 to
e9eba08
Compare
PringlesGang
approved these changes
Feb 15, 2026
KKhanhH
approved these changes
Feb 18, 2026
| ScrWork[SW_SYSSUBMENUCT] == 0) { | ||
| State = Hidden; | ||
| MainItems.IsShown = false; | ||
| MainItems.VisibilityState = Shown; |
| } | ||
| MainItems.Hide(); | ||
| MainItems.IsShown = true; | ||
| MainItems.VisibilityState = Shown; |
Collaborator
There was a problem hiding this comment.
This is technically Hiding state but we don't really have anything for that rn
- Decouple Update and UpdateInput for Group - Add separate UpdateInput call for relevant groups - Fix CHLCC Music Menu out of bounds hover - Use Enum state instead of boolean
Gunoshozo
force-pushed
the
group-input-refactor
branch
from
1ed044f to
d3de3fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group Input Refactor