This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Rearrange extension imports of CBT.NuGet#107
Merged
jeffkl merged 2 commits intoCommonBuildToolset:masterfrom May 17, 2017
jeffkl:beforecbtnugetprops
Merged
Rearrange extension imports of CBT.NuGet#107jeffkl merged 2 commits intoCommonBuildToolset:masterfrom jeffkl:beforecbtnugetprops
jeffkl merged 2 commits intoCommonBuildToolset:masterfrom
jeffkl:beforecbtnugetprops
Conversation
Change the import order for Before.CBT.NuGet.props and give another extension point for other modules like GlobalRestore
kingerja
approved these changes
May 17, 2017
Contributor
kingerja
left a comment
kingerja
left a comment
There was a problem hiding this comment.
Looks good though this is a high risk module so we should be extra through on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move up the import of Before.NuGet.props
Change CBT.GlobalRestore to use After.CBT.NuGet.props