Skip to content
This repository was archived by the owner on Jul 14, 2020. It is now read-only.

support packagereference in leaf node projects#110

Merged
kingerja merged 5 commits intoCommonBuildToolset:masterfrom
kingerja:iss102
May 22, 2017
Merged

support packagereference in leaf node projects#110
kingerja merged 5 commits intoCommonBuildToolset:masterfrom
kingerja:iss102

Conversation

@kingerja
Copy link
Copy Markdown
Contributor

Added support for nuget 4.x which allows <PackageReference
Added Directory.Build.props but left build.props in place to import directory.build.props to prepare for transition to directory.build.props.

#102

Josh Kingery added 3 commits May 19, 2017 16:48
set
CBTEnablePackageRestore=false
CBTModulesRestored=true
To break infinite loop when calling nuget.
…t to allow support for msbuild 15 coolness and maintain old project imports.
@kingerja kingerja requested a review from jeffkl May 20, 2017 00:19
Comment thread src/CBT.NuGet/Tasks/NuGetRestore.cs Outdated

public override bool Execute()
{
EnvironmentVariables = new[] { $"CBTEnablePackageRestore=false", $"CBTModulesRestored=true" };
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a comment here explaining why this is needed and have each item on a new line so its more obvious that two vars are being set.

@kingerja kingerja added this to the Sprint 2 milestone May 22, 2017
@kingerja kingerja merged commit 441b4c5 into CommonBuildToolset:master May 22, 2017
@kingerja kingerja deleted the iss102 branch May 22, 2017 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants