Skip to content
This repository was archived by the owner on Jul 14, 2020. It is now read-only.

Get /t:Restore to work.#117

Merged
kingerja merged 3 commits intoCommonBuildToolset:masterfrom
kingerja:iss104
May 24, 2017
Merged

Get /t:Restore to work.#117
kingerja merged 3 commits intoCommonBuildToolset:masterfrom
kingerja:iss104

Conversation

@kingerja
Copy link
Copy Markdown
Contributor

Don't require VS to be installed for nuget to work.

This requires about 20 megs of checked in binaries I tried started off with only the ones needed however every different scenario seemed to required more binaries and after I was past 30 binaries being pulled in I just opted to grab the whole folder to reduce the chance of there being an issue.

This approach effectively locks this module to a specific version of these restore targets. We could go the route of only conditionally using our targets if they are not already installed on the box. I personally strongly dislike that approach as it puts us at the mercy of machine installs and makes builds unpredictable which in my book is huge. But the cost of owning this package may become significant. Perhaps we can push the nuget team to release this functionality as a nuget package.

Also I updated the version of Module\Microsoft.Nuget\Newtonsoft.Json.dll to the correct version. 8.0.0.0

Anyway if you have a better idea to make this cleaner please let me know. And if you know of an official pre-existing nuget package that packs these files then let me know about that too.

Issue #104

Don't require VS to be installed for nuget to work.
@kingerja kingerja added this to the Sprint 2 milestone May 23, 2017
@kingerja kingerja requested a review from jeffkl May 23, 2017 21:12
Josh Kingery added 2 commits May 23, 2017 14:14
…e a dummy restore target that is overridden by nuget restore targets if present.
@kingerja
Copy link
Copy Markdown
Contributor Author

As discussed going with the route of not shipping the nuget restore targets and simply creating a dummy restore target that does nothing in the command line scenario where VS is not installed. If VS is installed with these nuget targets then the dummy restore target will be overridden providing the user with the nuget experience.

@kingerja kingerja merged commit 06630c1 into CommonBuildToolset:master May 24, 2017
@kingerja kingerja deleted the iss104 branch May 24, 2017 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants