This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Get /t:Restore to work.#117
Merged
kingerja merged 3 commits intoCommonBuildToolset:masterfrom May 24, 2017
kingerja:iss104
Merged
Get /t:Restore to work.#117kingerja merged 3 commits intoCommonBuildToolset:masterfrom kingerja:iss104
kingerja merged 3 commits intoCommonBuildToolset:masterfrom
kingerja:iss104
Conversation
Don't require VS to be installed for nuget to work.
added 2 commits
May 23, 2017 14:14
…e a dummy restore target that is overridden by nuget restore targets if present.
Contributor
Author
|
As discussed going with the route of not shipping the nuget restore targets and simply creating a dummy restore target that does nothing in the command line scenario where VS is not installed. If VS is installed with these nuget targets then the dummy restore target will be overridden providing the user with the nuget experience. |
jeffkl
approved these changes
May 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require VS to be installed for nuget to work.
This requires about 20 megs of checked in binaries I tried started off with only the ones needed however every different scenario seemed to required more binaries and after I was past 30 binaries being pulled in I just opted to grab the whole folder to reduce the chance of there being an issue.
This approach effectively locks this module to a specific version of these restore targets. We could go the route of only conditionally using our targets if they are not already installed on the box. I personally strongly dislike that approach as it puts us at the mercy of machine installs and makes builds unpredictable which in my book is huge. But the cost of owning this package may become significant. Perhaps we can push the nuget team to release this functionality as a nuget package.
Also I updated the version of Module\Microsoft.Nuget\Newtonsoft.Json.dll to the correct version. 8.0.0.0
Anyway if you have a better idea to make this cleaner please let me know. And if you know of an official pre-existing nuget package that packs these files then let me know about that too.
Issue #104