This repository was archived by the owner on Jul 14, 2020. It is now read-only.
autoimport build packages if also modules#119
Merged
kingerja merged 7 commits intoCommonBuildToolset:masterfrom Jun 2, 2017
kingerja:iss44
Merged
autoimport build packages if also modules#119kingerja merged 7 commits intoCommonBuildToolset:masterfrom kingerja:iss44
kingerja merged 7 commits intoCommonBuildToolset:masterfrom
kingerja:iss44
Conversation
jeffkl
reviewed
Jun 1, 2017
| foreach (BuildPackageInfo buildPackageInfo in ModulePaths.Select(BuildPackageInfo.FromModulePath).Where(i => i != null)) | ||
| { | ||
| ProjectPropertyElement enableProperty = propertyGroup.AddProperty(buildPackageInfo.EnablePropertyName, "false"); | ||
| bool defaultEnableValue = false; |
Contributor
There was a problem hiding this comment.
Okay I finally understand what you're trying to do. If its a module because it has a module.config, its imported by default. However, there's no guarantee that people will be using the CBT.NuGet module in their code bases. So if all modules have a layout like:
CBT.Traversal
└─build
CBT.Traversal.props
module.config
Traversal.targets
And we eliminate the proprietary build.props, then we want them to work with or without the CBT.NuGet module. So CBT.Core should import CBT.Traversal.props like it does build.props and CBT.NuGet should only generate imports for build packages that are not modules.
added 6 commits
June 1, 2017 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically enable import of any build imports if it is also a cbt module package.