This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Add support for IncludeAssets, ExcludeAssets, and PrivateAssets#207
Merged
jeffkl merged 4 commits intoCommonBuildToolset:masterfrom Dec 7, 2017
jeffkl:IncludeAssets_ETC
Merged
Add support for IncludeAssets, ExcludeAssets, and PrivateAssets#207jeffkl merged 4 commits intoCommonBuildToolset:masterfrom jeffkl:IncludeAssets_ETC
jeffkl merged 4 commits intoCommonBuildToolset:masterfrom
jeffkl:IncludeAssets_ETC
Conversation
kingerja
approved these changes
Nov 20, 2017
kingerja
reviewed
Dec 7, 2017
| <!-- | ||
| The path to a file written to when validating to not run validation unless it is necessary. | ||
| --> | ||
| <NuGetDeterministicPackagesValidatedFile Condition=" '$(NuGetDeterministicPackagesValidatedFile)' == '' ">$(IntermediateOutputPath)$(MSBuildProjectFile).ndpv</NuGetDeterministicPackagesValidatedFile> |
Contributor
There was a problem hiding this comment.
in non cloudbuild scenario can we rely on IntermediateOutputPath being set yet?
Contributor
Author
There was a problem hiding this comment.
Good point. I ended up removing this logic anyway since the validation only really happens once in a hosted build. Not to mention that you were right that it was only happening once even on a multi-targeted build...
kingerja
approved these changes
Dec 7, 2017
This fixes a build warning when targeting .NET Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently disables the NuGetDeterministicOverWritePropsFile property
Includes unit tests