This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Handle case when LoggingService is not created by BuildManager#73
Merged
jeffkl merged 1 commit intoCommonBuildToolset:masterfrom Mar 14, 2017
jeffkl:nulref
Merged
Handle case when LoggingService is not created by BuildManager#73jeffkl merged 1 commit intoCommonBuildToolset:masterfrom jeffkl:nulref
jeffkl merged 1 commit intoCommonBuildToolset:masterfrom
jeffkl:nulref
Conversation
When parsing an MSBuild project outside of a build, the BuildManager does not have a LoggingService instance. Accessing the property throws an exception and becomes noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an MSBuild project outside of a build, the BuildManager does not have a LoggingService instance. Accessing the property throws an exception and becomes noise.