Skip to content

added two sparql qcs, updated others#469

Merged
APCox merged 3 commits intodevelopfrom
sparql-qc-checks
Sep 13, 2024
Merged

added two sparql qcs, updated others#469
APCox merged 3 commits intodevelopfrom
sparql-qc-checks

Conversation

@johnbeve
Copy link
Copy Markdown
Contributor

No description provided.

@mark-jensen
Copy link
Copy Markdown

@johnbeve Do you need the definition whitespace check since also have one for all annotations?

@swartik
Copy link
Copy Markdown
Contributor

swartik commented Sep 11, 2024

A few consistency issues:

  • Some of the queries include ?error in the results, others don't.
  • Sometimes ?error is the first term in the results, sometimes the last.
  • On line 16 of annotation_whitespace.sparql, change annotation values have to annotation value has. Each result will always return a single annotation value.

Question: the Makefile uses the --fail-on-violation false flag. Is the plan to have errors cause failure in v1.6, or will that happen later?

@APCox APCox merged commit ca2f266 into develop Sep 13, 2024
@johnbeve johnbeve deleted the sparql-qc-checks branch September 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants