Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Repo changelog support in auditquery#19

Merged
ligangty merged 2 commits intoCommonjava:masterfrom
ligangty:changelog
May 24, 2019
Merged

Repo changelog support in auditquery#19
ligangty merged 2 commits intoCommonjava:masterfrom
ligangty:changelog

Conversation

@ligangty
Copy link
Member

@ligangty ligangty commented May 21, 2019

A very draft stub of UI for change log part, not support search yet. It will show all change log now in the cache. Server-side pagination with searching should be added in another patch.

@ligangty ligangty changed the title Repo changelog support in auditquery A very draft stub of UI for change log part, not support search yet. It will show all change log now in the cache. Server-side pagination with searching should be added in another patch. Repo changelog support in auditquery May 21, 2019
Copy link
Member

@sswguo sswguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two minor changes.

@ligangty ligangty requested review from jdcasey, ruhan1 and sswguo May 21, 2019 13:04
Copy link
Member

@sswguo sswguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor one.

public void readExternal( ObjectInput in )
throws IOException, ClassNotFoundException
{
this.storeKey = (String) in.readObject();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to check the version here and see if that's compatible. But looks fine atm.

@ligangty ligangty merged commit 0213ea1 into Commonjava:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants