Add file progress counters to upload / delete logs #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcasey
force-pushed
the
file-transfer-counters
branch
from
6aba202 to
8cd4a93
Compare
Pull Request Test Coverage Report for Build 1550470305
💛 - Coveralls |
jdcasey
force-pushed
the
file-transfer-counters
branch
from
8cd4a93 to
f3aab3b
Compare
ligangty
reviewed
Dec 6, 2021
charon/storage.py
Outdated
| if path.startswith(slash_root): | ||
| path = path[len(slash_root):] | ||
| if not fn(full_path, path): | ||
| if not fn(full_path, path, index, len(file_paths)): |
Member
There was a problem hiding this comment.
I think this len(file_paths) should be stored in a var to avoid run in a loop.
jdcasey
force-pushed
the
file-transfer-counters
branch
from
f3aab3b to
3568e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a little easier to see how the upload is progressing, even though you really only have progress for each type of operation within the upload / delete.