Skip to content

Chore: some code optimization #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdcasey merged 1 commit into from
Dec 9, 2021
Merged

Chore: some code optimization #113

jdcasey merged 1 commit into from
Dec 9, 2021

Conversation

@ligangty
Copy link
Member

@ligangty ligangty commented Dec 9, 2021 •
edited
Loading

  • Add type hint for s3 related objects
  • Extract constants to tests.commons from npm tests
  • Move some members and methods of S3Client to private

@coveralls
Copy link

coveralls commented Dec 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1557127774

  • 45 of 46 (97.83%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/storage.py 45 46 97.83%
Totals Coverage Status
Change from base Build 1551277766: 0.02%
Covered Lines: 1305
Relevant Lines: 1595
💛 - Coveralls

@ligangty
Chore: some code optimization
d5b4655 
  * Add type hint for s3 related objects
  * Extract constants to tests.commons from npm tests
@ligangty ligangty requested review from jdcasey and yma955 December 9, 2021 08:22
yma955
yma955 approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@yma955 yma955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdcasey jdcasey merged commit dc7c92f into Commonjava:main Dec 9, 2021
@ligangty ligangty deleted the chore branch December 10, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdcasey jdcasey jdcasey approved these changes

@yma955 yma955 yma955 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ligangty @coveralls @jdcasey @yma955