Skip to content

Conversation

@ligangty
Copy link
Member

We found that AWS file metadata has length limitation, which means
not suitable to store long information like products info. So we need to
use a new file *.prodinfo for each uploaded files. Rules:

  • Only product tarball valid files should contain this prodinfo file
  • Metadta files like maven-metadata or npm package leveled
    package.json or index files will not have this prodinfo.

   We found that AWS file metadata has length limitation, which means
not suitable to store long information like products info. So we need to
use a new file *.prodinfo for each uploaded files. Rules:
   * Only product tarball valid files should contain this prodinfo file
   * Metadta files like maven-metadata or npm package leveled
     package.json or index files will not have this prodinfo.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1577166510

  • 39 of 57 (68.42%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 80.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/storage.py 38 56 67.86%
Files with Coverage Reduction New Missed Lines %
charon/storage.py 2 81.85%
Totals Coverage Status
Change from base Build 1571907127: -0.3%
Covered Lines: 1337
Relevant Lines: 1659

💛 - Coveralls

@ligangty
Copy link
Member Author

@yma88 There are changes in npm package processing, which remove the product in metadata uploading. We will not track product info for all Charon generated files as they are meaningless. Please help check if this will bring any npm logic.

{% else %}
{% for item in index.items %}
<li><a href="{{ item }}" title="{{ item }}">{{ item }}</a></li>
{% endif %}{% endfor%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this same thing need to be changed in templates/index.html.j2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the constant's one will be used if the template is not specified in $HOME/.charon/templates folder. But for consistency it is needed to be changed. I'll add it later.

@jdcasey jdcasey merged commit bebc032 into Commonjava:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants