Skip to content

Conversation

@ligangty
Copy link
Member

Current ignore_patterns only address the file names, but not the whole
direcotries. It's a little hard to use this regex patterns to decide if
the whole path should be ignored by the pattern.
This pr added a new configuration "ignore_dirs", which means all files
in these ignored_dirs will be ignored for uploading and removing,
wherever these dirs located (root or the sub folder)

@ligangty ligangty requested a review from jdcasey December 16, 2021 12:32
@ligangty
Copy link
Member Author

@jdcasey I found that the GA uploading contains the .index .meta and .nexus folders. This is because the ignore_patterns only works for file names, but not the whole path. This PR is fixing the problems.
For the uploaded stuff in these ignored folder, I think we can remove it manually later, and just update the root index.html.

@coveralls
Copy link

coveralls commented Dec 16, 2021

Pull Request Test Coverage Report for Build 1767940684

  • 27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 79.001%

Totals Coverage Status
Change from base Build 1767930659: 0.3%
Covered Lines: 1328
Relevant Lines: 1681

💛 - Coveralls

@ligangty
Copy link
Member Author

Will hold this as we decide to ignore this fix in current phase.

ligangty added 2 commits March 6, 2022 20:05
  Current ignore_patterns only address the file names, but not the whole
  direcotries. It's a little hard to use this regex patterns to decide if
  the whole path should be ignored by the pattern.
  This pr added a new configuration "ignore_dirs", which means all files
  in these ignored_dirs will be ignored for uploading and removing,
  wherever these dirs located (root or the sub folder)
@ligangty
Copy link
Member Author

ligangty commented May 5, 2022

This fix is not needed anymore. Closed.

@ligangty ligangty closed this May 5, 2022
@ligangty ligangty deleted the ignore branch June 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants