Skip to content

Chore: adjust logging #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ligangty merged 1 commit into from
Mar 9, 2022
Merged

Chore: adjust logging #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions charon/pkgs/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,17 +316,16 @@ def handle_maven_uploading(
root=top_level
)
logger.info("Files uploading done\n")

succeeded = True
for target in targets:
# 5. Do manifest uploading
manifest_folder = target[0]
logger.info("Start uploading manifest to s3 bucket %s", manifest_bucket_name)
if not manifest_bucket_name:
logger.warning(
'Warning: No manifest bucket is provided, will ignore the process of manifest '
'uploading\n')
else:
logger.info("Start uploading manifest to s3 bucket %s", manifest_bucket_name)
manifest_folder = target[0]
manifest_name, manifest_full_path = write_manifest(valid_mvn_paths, top_level, prod_key)
s3_client.upload_manifest(
manifest_name, manifest_full_path,
Expand Down
2 changes: 1 addition & 1 deletion charon/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ async def __copy_between_bucket(
self, source: str, source_key: str,
target: s3.Bucket, target_key: str
) -> bool:
logger.info(
logger.debug(
"Copying file %s from bucket %s to target %s as %s",
source_key, source, target.name, target_key)
copy_source = {
Expand Down