Skip to content

Conversation

@yma955
Copy link
Member

@yma955 yma955 commented Apr 11, 2022

Now considered npm version-level package.json is a sort of special metadata in Charon. It's partially generated from Charon, and most fields are coming from uploading. We still need to keep its .prodinfo to make it able to roll back thoroughly, so manifest will keep it as well.

@yma955 yma955 requested a review from ligangty April 11, 2022 04:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2146224160

  • 11 of 14 (78.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 78.66%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/storage.py 5 8 62.5%
Totals Coverage Status
Change from base Build 2100968136: 0.3%
Covered Lines: 1515
Relevant Lines: 1926

💛 - Coveralls

Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yma955 yma955 merged commit c031315 into Commonjava:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants