Skip to content

chore: fix a return value and a var declare issue #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: fix a return value and a var declare issue #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions charon/pkgs/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,10 +862,9 @@ def _generate_upload_archetype_catalog(
available in the bucket. Merge (or unmerge) these catalogs and
return a boolean indicating whether the local file should be uploaded.
"""
remote = ARCHETYPE_CATALOG_FILENAME
if prefix:
remote = os.path.join(prefix, ARCHETYPE_CATALOG_FILENAME)
else:
remote = ARCHETYPE_CATALOG_FILENAME
local = os.path.join(root, ARCHETYPE_CATALOG_FILENAME)
# As the local archetype will be overwrittern later, we must keep
# a cache of the original local for multi-targets support
Expand All @@ -884,7 +883,7 @@ def _generate_upload_archetype_catalog(
logger.error(
"Error: Can not generate archtype-catalog.xml due to: %s", e
)
return 0
return False
if not existed:
__gen_all_digest_files(local)
# If there is no catalog in the bucket, just upload what we have locally
Expand Down