Skip to content

Conversation

@ligangty
Copy link
Member

@ligangty ligangty commented Dec 16, 2024

This bug happens when we are deleting a npm package whose name has overlapping with other package, for example,
if a package name is "backstage-plugin-orchestrator" and the registry already has another package whose name is "backstage-plugin-orchestrator-backend-dynamic", the charon will report error. This PR will fix the issue.

In the meantime, the "maintainers" and "keywords" fields may be empty in the package.json, which also causes some None type issue. This PR also fixed it.

…apped name with others

Signed-off-by: Gang Li <ligangty@users.noreply.github.com>
@ligangty ligangty requested a review from yma955 December 16, 2024 01:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12344397908

Details

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 66.564%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/pkgs/npm.py 12 16 75.0%
Totals Coverage Status
Change from base Build 11098505398: 0.2%
Covered Lines: 1947
Relevant Lines: 2925

💛 - Coveralls

@ligangty
Copy link
Member Author

@yma96 Please help check if this change makes sense.

@yma955
Copy link
Member

yma955 commented Dec 16, 2024

LGTM

@ligangty ligangty merged commit b390ee1 into Commonjava:main Dec 16, 2024
17 checks passed
@ligangty ligangty deleted the overlap branch December 16, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants