Skip to content

Conversation

@ligangty
Copy link
Member

No description provided.

@ligangty ligangty merged commit 48ec92a into Commonjava:main May 26, 2025
17 checks passed
radas_config: Dict = data.get("radas", None)
if radas_config:
self.__radas_config__ = RadasConfig(radas_config)
self.__radas_config = RadasConfig(radas_config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ligangty If no Optional to initialize the __radas_config, I'm afraid it will report AttributeError: CharonConfig object has no attribute radas_config when the method get_radas_config is called without radas_config there, we have some places that call this method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. I'll correct it. Thanks

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15249017201

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 18 (50.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 63.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/pkgs/radas_signature_handler.py 3 4 75.0%
charon/cmd/cmd_sign.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
charon/cmd/cmd_sign.py 1 0.0%
Totals Coverage Status
Change from base Build 15180796871: -0.04%
Covered Lines: 2038
Relevant Lines: 3188

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants