Feat: Accept multiple maven zips with non-RADAS signing way #350
Conversation
ligangty
left a comment
ligangty
left a comment
There was a problem hiding this comment.
@yma96 sorry for late review. Please see comments.
charon/pkgs/maven.py
Outdated
| src_file = os.path.join(root_dir, file) | ||
| dest_file = os.path.join(dest_root, file) | ||
| if os.path.exists(dest_file): | ||
| overwritten_count += 1 |
There was a problem hiding this comment.
I don't think we should do this overwritten copy. Instead we can just mark it as "duplicated"
There was a problem hiding this comment.
I just think one case: if has two same files name, but content may not be consistent, we will always keep the latter coming one as the latest to override, @ligangty WDYT?
I also thought of the checksum method, but it might cost much for the thousands of comparisons, but such situations that require override are rare.
There was a problem hiding this comment.
No need to do this, because we don't know which one is the right one. If there is overlapping, let's always consider the first one as the right one.
ligangty
left a comment
ligangty
left a comment
There was a problem hiding this comment.
Ok. Let's merge this PR and see the test result to see if any issues.
2 participants
No description provided.