Skip to content

Fix: remove a redundant open operation #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Fix: remove a redundant open operation #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions charon/pkgs/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,17 +1032,16 @@ def _generate_rollback_archetype_catalog(
else:
# Re-render the result of our archetype un-merge to the
# local file, in preparation for upload.
with open(local, 'wb') as f:
content = MavenArchetypeCatalog(remote_archetypes)\
.generate_meta_file_content()
try:
overwrite_file(local, content)
except FileNotFoundError as e:
logger.error(
"Error: Can not create file %s because of some missing folders",
local,
)
raise e
content = MavenArchetypeCatalog(remote_archetypes)\
.generate_meta_file_content()
try:
overwrite_file(local, content)
except FileNotFoundError as e:
logger.error(
"Error: Can not create file %s because of some missing folders",
local,
)
raise e
__gen_all_digest_files(local)
return 1

Expand Down Expand Up @@ -1148,17 +1147,16 @@ def _generate_upload_archetype_catalog(
# Re-render the result of our archetype merge /
# un-merge to the local file, in preparation for
# upload.
with open(local, 'wb') as f:
content = MavenArchetypeCatalog(remote_archetypes)\
.generate_meta_file_content()
try:
overwrite_file(local, content)
except FileNotFoundError as e:
logger.error(
"Error: Can not create file %s because of some missing folders",
local,
)
raise e
content = MavenArchetypeCatalog(remote_archetypes)\
.generate_meta_file_content()
try:
overwrite_file(local, content)
except FileNotFoundError as e:
logger.error(
"Error: Can not create file %s because of some missing folders",
local,
)
raise e
__gen_all_digest_files(local)
return True

Expand Down