Skip to content

Conversation

@ligangty
Copy link
Member

No description provided.

@ligangty ligangty force-pushed the 1.3.x branch 3 times, most recently from fa732ac to 5cea07a Compare November 26, 2025 09:44
Assisted by: Claude code
merged_count += 1
logger.debug("Merged archetype catalog: %s -> %s", src_file, dest_file)
if os.path.exists(dest_file):
elif os.path.exists(dest_file):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yma955 I'm not sure if this change will break your logic, but from my POV this should be elif but not single if. Please help confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ligangty, you are right, we should update it to elif.

@ligangty ligangty requested a review from yma955 November 26, 2025 09:56
@ligangty
Copy link
Member Author

@yma955 Please help review one point I listed in comment. Thanks!

@ligangty ligangty merged commit 5c47930 into Commonjava:1.3.x Nov 27, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants