Skip to content

Conversation

@ligangty
Copy link
Member

@ligangty ligangty commented Dec 3, 2021

This pr will let uploading and deletion process of maven releases have support to append the prefix as root dir to all files.

   We will use prefix before all files path in some cases, so need a way
   to specify it.
@ligangty ligangty requested a review from jdcasey December 3, 2021 11:56
@ligangty
Copy link
Member Author

ligangty commented Dec 3, 2021

@jdcasey this pr only handles the maven process. For npm, it will be in another pr.

@ligangty ligangty requested a review from geored December 3, 2021 11:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1535091559

  • 60 of 65 (92.31%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 82.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/pkgs/indexing.py 13 14 92.86%
charon/pkgs/maven.py 21 22 95.45%
charon/utils/archive.py 0 1 0.0%
charon/cmd/command.py 0 2 0.0%
Totals Coverage Status
Change from base Build 1533707752: 0.4%
Covered Lines: 1113
Relevant Lines: 1352

💛 - Coveralls

@ligangty
Copy link
Member Author

ligangty commented Dec 3, 2021

@jdcasey @geored The bandit check failed on the ssl disablement of the requests lib, but when I'm doing tests I found it always failed to download from our internal tarball sites by the ssl checking. I'm not sure a better solution yet for this. Do you have any suggestions on this?

Copy link
Member

@jdcasey jdcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bandit failures seem to be having a problem not related to your code. It's either a problem in the linter or in the default verify value in requests for those packages. It's important to realize too that it could be a conflict between system packages (python-requests RPM) and pip packages. I think we should proceed and let someone fix the underlying package.

@jdcasey jdcasey merged commit fbd0a5e into Commonjava:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants