Open
Conversation
Member
|
@shokakucarrier Can you help check if this will bring some impact on indy code? |
Member
|
@ligangty yes it does, indy reference them in code base, we will have to adjust indy for that |
Contributor
Author
|
@shokakucarrier Should this be done as part of MMENG-4564 ? |
Member
I guess we should, I thought remove only the dependency part of galley would be enough, but since we are going to remove o11yphant from all repo now we will have to trim down codes like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #474